Test and fix for bug in selectMapimpl#726
Merged
zeroshade merged 4 commits intoapache:mainfrom Mar 25, 2026
Merged
Conversation
zeroshade
requested changes
Mar 24, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Can you include an explicit test of the case that was producing the corrupted parquet files for you? It looks like the issue is the case where the Value was nullable?
Contributor
Author
|
@zeroshade narrowed it down to just a failing test. 685678d |
Member
|
@wwarner-inf it looks like you dropped the fix from the commits by accident |
Contributor
Author
|
Not an accident -- I thought maybe you wanted a clean demonstration of the problem. It's here and sure I can put it back if that suits you! |
zeroshade
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Maps of Nullables produce corrupted parquet.
What changes are included in this PR?
The existing tests for
TakeKernelMapare made runnable by correcting the test json to be suitable input forarray.FromJSON(). Added a condition inassertTakeArrays()that checks that the data type has been preserved. Using the C++ implementation as a reference.Are these changes tested?
Yes, but not deeply.
Are there any user-facing changes?
The api is unchanged, however parquet output will change slightly for those files containing maps with optional values.