chore: remove tools.go files in favor of go.mod "tool" directive#759
Merged
zeroshade merged 1 commit intoapache:mainfrom Apr 13, 2026
Merged
chore: remove tools.go files in favor of go.mod "tool" directive#759zeroshade merged 1 commit intoapache:mainfrom
zeroshade merged 1 commit intoapache:mainfrom
Conversation
This prevents dependencies used for `//go:generate` from being included as a
direct dependency, while preserving the ability to specify the version to
use through go.mod (as `//indirect` dependency if not used elsehwere).
Tools specified in go.mod can be downloaded with `go get -tool`, e.g.;
go get -tool github.com/klauspost/asmfmt/cmd/asmfmt
Or ran with `go tool <name of tool>`.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
zeroshade
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents dependencies used for
//go:generatefrom being included as a direct dependency, while preserving the ability to specify the version to use through go.mod (as//indirectdependency if not used elsehwere).Tools specified in go.mod can be downloaded with
go get -tool, e.g.;Or ran with
go tool <name of tool>.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?