Skip to content

chore: remove mentions of compatibility with go toolchain < go1.18#760

Merged
zeroshade merged 1 commit intoapache:mainfrom
thaJeztah:rm_go_comments
Apr 12, 2026
Merged

chore: remove mentions of compatibility with go toolchain < go1.18#760
zeroshade merged 1 commit intoapache:mainfrom
thaJeztah:rm_go_comments

Conversation

@thaJeztah
Copy link
Copy Markdown
Contributor

The github.com/apache/arrow/go/v11/arrow/compute module was removed in commit f6e3442, making it part of the main module. The go version in go.mod was updated to go1.18, but older versions of the go toolchain could still be used;

Requirements

Despite the go.mod stating go1.18, everything except for the compute package
is able to be built with go1.17 (and most is also compatible with go1.16).

Before Go 1.21, the go line in go.mod was effectively advisory: older toolchains might still try to build the module, and only complain if they hit something unsupported. Starting with Go 1.21 (backported to go1.19.3 and go1.20.8), the go line became a strict minimum requirement. https://go.dev/doc/go1.21

Commit ddfa815 updated the go version in go.mod to go1.21.0, no longer allowing older toolchains to be used.

This patch removes the mentions of older toolchains.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

The github.com/apache/arrow/go/v11/arrow/compute module was removed in commit
f6e3442, making it part of the main module.
The go version in go.mod was updated to go1.18, but older versions of the go
toolchain could still be used;

> Requirements
>
> Despite the go.mod stating go1.18, everything except for the compute package
> is able to be built with go1.17 (and most is also compatible with go1.16).

Before Go 1.21, the go line in go.mod was effectively advisory: older toolchains
might still try to build the module, and only complain if they hit something
unsupported. Starting with Go 1.21 (backported to go1.19.3 and go1.20.8), the
go line became a strict minimum requirement. https://go.dev/doc/go1.21

Commit ddfa815 updated the go version in
go.mod to go1.21.0, no longer allowing older toolchains to be used.

This patch removes the mentions of older toolchains.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from zeroshade as a code owner April 12, 2026 17:21
@zeroshade zeroshade merged commit 2e44b72 into apache:main Apr 12, 2026
23 checks passed
@thaJeztah thaJeztah deleted the rm_go_comments branch April 13, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants