fix(parquet): clarify docstring on Close method of FileWriter, proper err output#774
Merged
zeroshade merged 1 commit intoapache:mainfrom Apr 21, 2026
Merged
Conversation
Member
Author
|
@tilinna is this what you were thinking? |
lidavidm
approved these changes
Apr 20, 2026
|
LGTM, although I would have classified this as fix(parquet) (there's a small code-change too) |
zeroshade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #703
What changes are included in this PR?
Clarifying the docstrings on the Close methods of the FileWriter and pqarrow.FileWriter
Are these changes tested?
Documentation changes, no need to test
Are there any user-facing changes?
No