GH-1098: [Java][Vector] Fix always-true precondition check in LargeListVector.setValueCount#1099
Open
LuciferYang wants to merge 1 commit intoapache:mainfrom
Open
Conversation
…argeListVector.setValueCount
LuciferYang
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
Author
|
Could a maintainer please add the bug-fix label to this PR? I don't have label permissions on this repository. Thank you! |
ennuite
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Good one. I looked into this: the bug has been there since the class was created, see 4deba44#diff-c3066ea815144f3e05b277c87cae8a7701f0f1481e15da508261664ab017d944R984
The PR fixes the bug and has test coverage for all equivalence classes. The correct values are in the interval [0, Integer.MAX_Value]; there are tests for a negative value, 0, a positive value smaller than Integer.MAX_Value, Integer.MAX_Value and a positive value greater than Integer.MAX_Value.
Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fix the precondition check in
LargeListVector.setValueCount()where||made the condition always true (childValueCount <= Integer.MAX_VALUE || childValueCount >= Integer.MIN_VALUEis a tautology for anylongvalue), allowing silent data corruption whenchildValueCountexceedsInteger.MAX_VALUEor is negative.Changes:
||with&&andInteger.MIN_VALUEwith0to correctly boundchildValueCountto[0, Integer.MAX_VALUE], consistent withLargeListViewVectorchildValueCountInteger.MAX_VALUEvaluesCloses #1098.