Skip to content

delete deprecations in preparation for v2.0 release#241

Merged
jrevels merged 2 commits into
mainfrom
jr/ripdeps
Sep 22, 2021
Merged

delete deprecations in preparation for v2.0 release#241
jrevels merged 2 commits into
mainfrom
jr/ripdeps

Conversation

@jrevels
Copy link
Copy Markdown
Contributor

@jrevels jrevels commented Sep 20, 2021

Follow-up to #238.

Unsure whether I've hit everything we'd want to cover here, but at least hits the items that I remembered/stood out in the code to me.

@jrevels jrevels requested a review from quinnj September 20, 2021 09:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2021

Codecov Report

Merging #241 (4280ea9) into main (cd468ef) will increase coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   85.84%   86.45%   +0.60%     
==========================================
  Files          26       26              
  Lines        3265     3234      -31     
==========================================
- Hits         2803     2796       -7     
+ Misses        462      438      -24     
Impacted Files Coverage Δ
src/ArrowTypes/src/ArrowTypes.jl 87.59% <ø> (+9.66%) ⬆️
src/arraytypes/arraytypes.jl 89.32% <ø> (+0.32%) ⬆️
src/utils.jl 83.63% <ø> (+4.32%) ⬆️
src/eltypes.jl 86.50% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd468ef...4280ea9. Read the comment docs.

Copy link
Copy Markdown
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

quinnj referenced this pull request Sep 22, 2021
@jrevels jrevels merged commit 38e5dea into main Sep 22, 2021
@jrevels jrevels deleted the jr/ripdeps branch September 22, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants