Owning/mutable struct ArrowArray
#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Aug 5, 2022
lidavidm
reviewed
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 91.97% 92.37% +0.39%
==========================================
Files 5 8 +3
Lines 798 931 +133
Branches 30 35 +5
==========================================
+ Hits 734 860 +126
- Misses 41 45 +4
- Partials 23 26 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lidavidm
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5 by implementing an Array whose buffer lifecycle is handled by
struct ArrowBuffer.