fix(azure): fall back to client-side filtering for list_with_offset on OneLake#696
Open
kevinjqliu wants to merge 5 commits intoapache:mainfrom
Open
fix(azure): fall back to client-side filtering for list_with_offset on OneLake#696kevinjqliu wants to merge 5 commits intoapache:mainfrom
kevinjqliu wants to merge 5 commits intoapache:mainfrom
Conversation
This was referenced Apr 23, 2026
Merged
Contributor
Author
|
Need to rebase #694 to pass CI |
This was referenced Apr 23, 2026
Open
Contributor
Author
|
@tustvold could you take a look? |
rtyler
approved these changes
Apr 23, 2026
9b2d474 to
c014f56
Compare
Contributor
Author
|
rebased to pull in #694 |
rtyler
approved these changes
Apr 28, 2026
Contributor
rtyler
left a comment
There was a problem hiding this comment.
The only suggestion that I have is to provide a true listing of the OneLake location used for the manual testing in case anybody motivated enough to come along and try that manual test later needs to 😄
Is there a publicly linkable reference to the bug witht he OneLake service that can be referenced as well?
I am cautiously optimistic that this could get into a 0.13.3 so some downstream breaks can be resolved ahead of 0.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #695.
Rationale for this change
list_with_offsetreturns empty results on OneLake when both of the following conditions are met:onelake.blob.fabric.microsoft.com/MyWorkspace/lakehouse.Lakehouse/...) rather than by GUIDstartFromquery parameter — theList Blobsrequest includesstartFrom, which OneLake silently ignores in this case, returning 200 OK with zero results rather than rejecting the request(Note that when using GUID-based URLs (
onelake.blob.fabric.microsoft.com/{workspace-guid}),startFromworks correctly.)This regression was introduced in #623 which implemented optimizations using
startFrompushdown.We (The OneLake team) are actively fixing
startFromwith friendly-name URLs on our side.In the meantime,
object_storecan fall back to client-side filtering for OneLake endpoints.I created a tracking issue (#697) to re-enable this optimization for OneLake once the fix is complete
What changes are included in this PR?
*.fabric.microsoft.com) and skipstartFrom, falling back to client-side filtering -- same approach already used for Azurite#[ignore]integration test (test_onelake_list_with_offset) that verifies offset exclusivity, boundary cases, and ordering against a live OneLake endpointTested locally
GUID-based URI works:
Friendly name based URI fails:
Are there any user-facing changes?
No, this is a behavioral change for
list_with_offsetagainst OneLake endpoints