Skip to content

Document use of unsafe in src/array/*.rs #149

@alamb

Description

@alamb

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-10980

This needs to be broken down into smaller tasks

 
There are ~32 uses of unsafe insrc/array/*.rs and we should document them according to the guidelines in the Arrow crate README

 
{code:java}
// JUSTIFICATION
// Benefit
// Describe the benefit of using unsafe. E.g.
// "30% performance degradation if the safe counterpart is used, see bench X."
// Soundness
// Describe why the code remains sound (according to the definition of rust's unsafe code guidelines). E.g.
// "We bounded check these values at initialization and the array is immutable."
let ... = unsafe { ... }; {code}

Metadata

Metadata

Assignees

No one assigned

    Labels

    arrowChanges to the arrow cratesecurity

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions