fix: Reject empty strings when casting strings to decimal#10010
Open
neilconway wants to merge 1 commit into
Open
fix: Reject empty strings when casting strings to decimal#10010neilconway wants to merge 1 commit into
neilconway wants to merge 1 commit into
Conversation
neilconway
force-pushed
the
neilc/fix-decimal-parse-empty-string
branch
from
7ab35ab to
9dc7e20
Compare
Contributor
Author
|
@Jefffrey If you have a moment, can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When casting string values to decimal,
parse_string_to_decimal_nativetreated empty strings and whitespace-only strings as valid input, resulting in a decimal with a value of 0. This is inconsistent withparse_decimaland how parsing and string -> numeric casts work for floating point types: in all of those cases, empty strings and whitespace-only strings are rejected.What changes are included in this PR?
parse_string_to_decimal_nativeto reject empty strings and whitespace-only stringsAre these changes tested?
Yes, new tests added.
Are there any user-facing changes?
Yes, this changes the behavior of string -> decimal casts. The previous behavior is (IMO) clearly incorrect but it is possible that some user code relies upon it.