[Variant] Preserve UUID extension type metadata for Parquet writer#10015
Draft
sdf-jkl wants to merge 1 commit into
Draft
[Variant] Preserve UUID extension type metadata for Parquet writer#10015sdf-jkl wants to merge 1 commit into
UUID extension type metadata for Parquet writer#10015sdf-jkl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Shredding into
FixedSizeBinary(16)means we're shredding intoUUIDParquet logical type.shred_variantcurrently doesn't preserve extension type metadata for the typed value field.UUID is the only valid
Variantshredding type that requires an arrow extension type. https://github.com/apache/parquet-format/blob/master/VariantShredding.mdEarlier in # @scovich mentioned:
This is an argument proposing to use
Fieldinstead ofDataTypeforas_typeparameter inshred_variant. This should not be an issue because arrow has aDecimal128Typeto representDecimal128logical Parquet type. This way there's no ambiguity in usingFixedSizeBinary(16)arrow type to representUUID. Switchingas_typetoFieldis unnecessary.What changes are included in this PR?
VariantArray::from_parts/ShreddedVariantFieldArray::from_partsnow addUUIDextension type metadata to the typed_valueFieldifDataTypeisFixedSizeBinary(16)UUIDextension part metadata validation in a unit test.Are these changes tested?
Are there any user-facing changes?
UUIDtyped value fields now preserveUUIDextension type metadata.