optimize(concat): concat map implementation#10048
Open
mapleFU wants to merge 1 commit into
Open
Conversation
mapleFU
commented
Jun 2, 2026
| Ok(Arc::new(array)) | ||
| } | ||
|
|
||
| fn concat_maps( |
Member
Author
There was a problem hiding this comment.
This copy the logic for List, I don't know can we share a offset based template impl here
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a native concat implementation for Arrow MapArray in arrow-select, avoiding the generic concat_fallback path and bringing Map in line with the existing optimized handling for List and Struct.
Changes:
- Added
concat_mapsto efficiently concatenateMapArrayinstances, including correct handling of sliced inputs and null buffers. - Updated
concatdispatch to routeDataType::Mapto the new implementation. - Added unit tests covering basic concatenation, sliced maps, null maps, and empty maps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Implement concat for map
What changes are included in this PR?
Implement concat for map
Are these changes tested?
Yes
Are there any user-facing changes?
No