Skip to content

Add coalesce inline-view filter benchmarks#10050

Merged
alamb merged 1 commit into
apache:mainfrom
ClSlaid:bench-9143-coalesce-inline-view-filter
Jun 2, 2026
Merged

Add coalesce inline-view filter benchmarks#10050
alamb merged 1 commit into
apache:mainfrom
ClSlaid:bench-9143-coalesce-inline-view-filter

Conversation

@ClSlaid
Copy link
Copy Markdown
Contributor

@ClSlaid ClSlaid commented Jun 2, 2026

This is a benchmark-only companion patch for #9755.

It keeps the functional changes out of this PR and only adds benchmark coverage in arrow/benches/coalesce_kernels.rs so the coalesce inline-view filter work can be tested independently.

Benchmark coverage included:

  • filter and take coalesce benchmarks
  • primitive schemas
  • single-column Utf8View and BinaryView
  • mixed primitive + Utf8View and primitive + BinaryView schemas
  • filter cases for short inline strings with max_string_len=8
  • filter/take cases for longer view strings, including max_string_len=20, 30, and 128 depending on scenario

Coverage note:

Validation:

cargo fmt --package arrow
cargo bench --bench coalesce_kernels -- --list
git diff --check

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Jun 2, 2026
@ClSlaid ClSlaid marked this pull request as ready for review June 2, 2026 17:58
@ClSlaid
Copy link
Copy Markdown
Contributor Author

ClSlaid commented Jun 2, 2026

@alamb The separated benchmark from #9755 is here, PTAL.

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ClSlaid

@alamb alamb merged commit cfc2b88 into apache:main Jun 2, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants