test(parquet): drop confusing main reference in page-roundtrip test comment#10072
Open
adriangb wants to merge 1 commit into
Open
test(parquet): drop confusing main reference in page-roundtrip test comment#10072adriangb wants to merge 1 commit into
main reference in page-roundtrip test comment#10072adriangb wants to merge 1 commit into
Conversation
… comment Follow-up to apache#9972. The test comment compared granular-mode page output to `main`, which is confusing now that the PR has merged into main. Compare to the default batched path instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #9972.
Rationale for this change
A test comment added in #9972 described granular mode as writing "more pages than
main". As noted in review feedback, comparing tomainis confusing now that the PR has merged — that code is main. This rephrases the comment to compare against the default batched path instead, which the same comment already references.What changes are included in this PR?
test_arrow_writer_granular_mode_roundtrip. No behavior change.Are there any user-facing changes?
No.
🤖 Generated with Claude Code