feat: Float16 cast #4180
Closed
feat: Float16 cast #4180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
May 9, 2023
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Some of the overflow behaviour seems unexpected, I could be mistaken but I thought that f16 had a similar range to f32, just lower precision?
arrow-cast/src/cast.rs
Outdated
| let f16_array: ArrayRef = Arc::new(Float16Array::from(f16_values)); | ||
|
|
||
| let f64_expected = vec
izveigor
commented
May 30, 2023
| ]; | ||
| let f16_array: ArrayRef = Arc::new(Float16Array::from(f16_values)); | ||
|
|
||
| let f64_expected = vec!["-inf", "-32768.0", "-128.0", "0.0", "255.0", "inf"]; |
Contributor
Author
There was a problem hiding this comment.
I didn't find the way in the package half how to replace inf with `null. Is this a serious problem?
Contributor
Author
|
@tustvold Sorry for the long delay. I left a few questions on this PR. Can you pay attention to them if you have time. |
Contributor
Author
|
So, what about this PR @tustvold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Support Float16Type in
cast.What changes are included in this PR?
Are there any user-facing changes?
Yes