Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Sep 9, 2021

Manual cherry-pick of 0e7c4c5 originally appearing in #712 and remove feature flag changes

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Sep 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #757 (21e7686) into active_release (486d5a3) will increase coverage by 0.01%.
The diff coverage is 48.27%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #757      +/-   ##
==================================================
+ Coverage           82.48%   82.49%   +0.01%     
==================================================
  Files                 167      167              
  Lines               46859    46901      +42     
==================================================
+ Hits                38651    38691      +40     
- Misses               8208     8210       +2     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 68.86% <44.44%> (+2.69%) ⬆️
parquet_derive_test/src/lib.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486d5a3...21e7686. Read the comment docs.

@alamb alamb changed the base branch from master to active_release September 9, 2021 20:28
@alamb alamb force-pushed the cherry_pick_0e7c4c5f branch from 3ff28fd to 21e7686 Compare September 9, 2021 20:29
@alamb
Copy link
Contributor Author

alamb commented Sep 9, 2021

@xrl FYI

Copy link
Contributor

@xrl xrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alamb alamb merged commit 9196a2a into active_release Sep 9, 2021
@alamb alamb deleted the cherry_pick_0e7c4c5f branch September 9, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants