Skip to content

Conversation

@erratic-pattern
Copy link
Contributor

@erratic-pattern erratic-pattern commented Jan 21, 2026

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @erratic-pattern -- I took the liberty of updating this test to also verify the output is correct, both with and without using the page index.

@alamb alamb merged commit 6f4d887 into apache:main Jan 22, 2026
17 checks passed
@sdf-jkl
Copy link
Contributor

sdf-jkl commented Jan 22, 2026

Why keep both selection and the first predicate, are they not creating the same selection?

@erratic-pattern
Copy link
Contributor Author

Why keep both selection and the first predicate, are they not creating the same selection?

This makes sense to me. I double checked again and it looks like the tag predicate could be removed.

@alamb
Copy link
Contributor

alamb commented Jan 22, 2026

Why keep both selection and the first predicate, are they not creating the same selection?

This makes sense to me. I double checked again and it looks like the tag predicate could be removed.

Follow on PR?

@sdf-jkl
Copy link
Contributor

sdf-jkl commented Jan 22, 2026

@alamb #9251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants