Move ListLikeArray to arrow-array to be shared with json writer and parquet unshredding#9437
Open
liamzwbao wants to merge 1 commit intoapache:mainfrom
Open
Move ListLikeArray to arrow-array to be shared with json writer and parquet unshredding#9437liamzwbao wants to merge 1 commit intoapache:mainfrom
ListLikeArray to arrow-array to be shared with json writer and parquet unshredding#9437liamzwbao wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
arrow
liamzwbao
changed the title
ListLikeArray to arrow-array to be shared with json writer and…ListLikeArray to arrow-array to be shared with json writer and parquet unshredding
liamzwbao
force-pushed
the
issue-9340-list-like-array-refactor
branch
from
7cc2313 to
419c537
Compare
… parquet unshredding
liamzwbao
force-pushed
the
issue-9340-list-like-array-refactor
branch
from
419c537 to
04680b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ListViewin arrow-json #9340.Rationale for this change
Json writers for ListLike types (List/ListView/FixedSizeList) are pretty similar apart from the element range representation. We already had a good way to abstract this kind of encoder in parquet variant unshredding. Given this, it would be good to move this
ListLikeArraytrait to arrow-array to be shared with json/parquetWhat changes are included in this PR?
Move
ListLikeArraytrait from parquet-variant-compute to arrow-arrayAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
New pub trait in arrow-array