Deprecate ArrowTimestampType::make_value in favor of from_naive_datetime#9491
Deprecate ArrowTimestampType::make_value in favor of from_naive_datetime#9491scovich merged 3 commits intoapache:mainfrom
Conversation
4b49135 to
65d0e0a
Compare
|
This piece of doc needs an update as well: https://arrow.apache.org/rust/arrow/datatypes/trait.ArrowTimestampType.html#method.from_naive_datetime |
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thanks @codephage2020 and @brunal
Maybe @sdf-jkl can also take a look
|
Thanks for looping me in, LGTM! |
scovich
left a comment
There was a problem hiding this comment.
LGTM, just one question about release timing
The docs will auto-generate on release. Any thoughts on the current code comments? |
|
All feedback has been addressed.thanks @scovich. |
|
Looks great. Taking @alamb approval without adding |
Mark ArrowTimestampType::make_value as deprecated and migrate internal callers to the newer from_naive_datetime API.
Which issue does this PR close?
Rationale for this change
Follow-up from PR #9345.
What changes are included in this PR?
Mark ArrowTimestampType::make_value as deprecated and migrate internal callers to the newer from_naive_datetime API.
Are these changes tested?
YES.
Are there any user-facing changes?
Migration Path: Users should replace:
With: