Skip to content

Deprecate ArrowTimestampType::make_value in favor of from_naive_datetime#9491

Merged
scovich merged 3 commits intoapache:mainfrom
codephage2020:issue-9490
Mar 2, 2026
Merged

Deprecate ArrowTimestampType::make_value in favor of from_naive_datetime#9491
scovich merged 3 commits intoapache:mainfrom
codephage2020:issue-9490

Conversation

@codephage2020
Copy link
Contributor

Mark ArrowTimestampType::make_value as deprecated and migrate internal callers to the newer from_naive_datetime API.

Which issue does this PR close?

Rationale for this change

Follow-up from PR #9345.

What changes are included in this PR?

Mark ArrowTimestampType::make_value as deprecated and migrate internal callers to the newer from_naive_datetime API.

Are these changes tested?

YES.

Are there any user-facing changes?

Migration Path: Users should replace:

// Old
TimestampSecondType::make_value(naive)

With:

// New
TimestampSecondType::from_naive_datetime(naive, None)

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 28, 2026
@codephage2020 codephage2020 marked this pull request as draft February 28, 2026 02:44
@github-actions github-actions bot added the parquet-variant parquet-variant* crates label Feb 28, 2026
@codephage2020 codephage2020 marked this pull request as ready for review February 28, 2026 05:40
@codephage2020
Copy link
Contributor Author

CC @alamb @sdf-jkl

@brunal
Copy link
Contributor

brunal commented Feb 28, 2026

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @codephage2020 and @brunal

Maybe @sdf-jkl can also take a look

@sdf-jkl
Copy link
Contributor

sdf-jkl commented Feb 28, 2026

Thanks for looping me in, LGTM!

Copy link
Contributor

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about release timing

@codephage2020
Copy link
Contributor Author

This piece of doc needs an update as well: https://arrow.apache.org/rust/arrow/datatypes/trait.ArrowTimestampType.html#method.from_naive_datetime

The docs will auto-generate on release. Any thoughts on the current code comments?

@codephage2020
Copy link
Contributor Author

All feedback has been addressed.thanks @scovich.

@scovich
Copy link
Contributor

scovich commented Mar 2, 2026

Looks great. Taking @alamb approval without adding next-major-release label as sufficient to merge this now.

@scovich scovich merged commit 9ec9f57 into apache:main Mar 2, 2026
29 checks passed
@codephage2020 codephage2020 deleted the issue-9490 branch March 3, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate ArrowTimestampType::make_value in favor of from_naive_datetime

5 participants