arrow-select: fix MutableArrayData interleave for ListView

[asubiotto]

The previous code did not extend child data buffers.

I'm preparing a PR for an optimized listview interleave, but wanted to make sure the fallback path was correct before comparing benchmarks.

Which issue does this PR close?

• Closes ListView interleave bug #9559
• Closes Fix MutableArrayData::extend for ListView #9562
• MutableArrayData::extend does not copy child values for ListView arrays #9561

Rationale for this change

Fix a bug

What changes are included in this PR?

Bugfix and test

Are these changes tested?

Yes

Are there any user-facing changes?

ListView interleaves did not succeed previously.

[asubiotto]

cc @alamb @brancz

[vegarsti]

Ha, funny timing! I have a PR for a native interleave here #9558. And I also discovered this bug yesterday 😄 #9561 My PR for this is #9562, but will close if/when this is merged.

[brancz]

I think I prefer #9562

[asubiotto]

Happy to go with whichever, my goal is to just fix this for MutableArrayData so we can compare the specialized interleave implementation fairly

[brancz]

Haha that was precisely my comment on #9558

[alamb]

I think I prefer #9562

😆 I think I actually prefer this one as the behavior is "less surprising" to me

let me know what you think

[alamb]

Thanks @asubiotto (and @vegarsti and @brancz )

compared to #9558, for me this PR is easier to understand and more consistent with the rest of the codebase. Other than the potential offset overflow I think it looks good from my perspective.

Let me know what you think

[brancz]

Works for me, let’s go with this one.

[vegarsti]

I agree! Thanks @alamb!

[asubiotto]

Sounds good, thanks all. Addressed the overflow comment so this should be ready to merge. @vegarsti I'll let you take care of the specialized interleave

[vegarsti]

Sounds good, thanks all. Addressed the overflow comment so this should be ready to merge. @vegarsti I'll let you take care of the specialized interleave

Nice, thanks!

[alamb]

Thank you @asubiotto @vegarsti and @brancz