Change occurances of truncate(0) to clear#9593
Open
Rafferty97 wants to merge 1 commit intoapache:mainfrom
Open
Change occurances of truncate(0) to clear#9593Rafferty97 wants to merge 1 commit intoapache:mainfrom
truncate(0) to clear#9593Rafferty97 wants to merge 1 commit intoapache:mainfrom
Conversation
`Vec`s but also one `MutableBuffer`. I also noticed and fixed an inconsistency between `MutableBuffer::truncate` and `MutableBuffer::clear`.
github-actions
bot
added
parquet
Dandandan
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
In response to a comment on #9494, I have searched for occurances of
truncate(0)and replaced them withclearto be more idiomatic. I know it's only a minor stylistic change, but it does help with code readability.In the process, I also noticed and fixed an inconsistency between
MutableBuffer::truncateandMutableBuffer::clear. Not sure if this is a latent bug or actually benign.Rationale for this change
Explained above
What changes are included in this PR?
truncate(0)withclearMutableBuffer::clearto be consistent withMutableBuffer::truncateAre these changes tested?
Yes, the existing test suite passes.
Are there any user-facing changes?
No