[Variant] Support Binary/LargeBinary children #9610
Open
AdamGS wants to merge 1 commit intoapache:mainfrom
Open
[Variant] Support Binary/LargeBinary children #9610AdamGS wants to merge 1 commit intoapache:mainfrom
AdamGS wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
commented
Mar 24, 2026
Comment on lines
+484
to
+488
| impl PartialEq for VariantArray { | ||
| fn eq(&self, other: &Self) -> bool { | ||
| self.inner == other.inner | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This replaces the derived implementation, I think it should be correct as all other members are derived from it.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
BinaryArray/LargeBinaryArrayin addition toBinaryViewArrayfor Variant #8387Rationale for this change
Improves spec compliance and improves performance, allowing more zero-copy copies between parquet and/or other implementation.
What changes are included in this PR?
The main change is replacing
VariantArray's children with opaqueArrayRef, and handling validation accordingly.Are these changes tested?
All existing tests are still in place.
Are there any user-facing changes?
Yes, some functions on
VariantArraynow take or returnArrayRef,from_parts,value_field,metadata_field.