ParquetMetaDataPushDecoder API to clear all buffered ranges#9673
Merged
alamb merged 3 commits intoapache:mainfrom Apr 13, 2026
Merged
Conversation
nathanb9
commented
Apr 8, 2026
etseidl
reviewed
Apr 9, 2026
Contributor
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
Thanks for the submission @nathanb9. Seems logical to me.
If it's not to much trouble could you also add an issue with a motivating use case? That aids in documentation for releases.
I also think it would be nice to add an example of the use of this API to the documentation at the head of push_decoder.rs.
Contributor
Author
|
@etseidl tysm. I added the motivating ticket which was create by alamb@ in the PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up for this ticket . Implement same API but for the metadata decoder.
See also #9624 (comment)
Rationale for this change
ParquetMetaDataPushDecoderclears exact requested ranges, but largerspeculative pushed ranges can remain buffered in
PushBuffers. Thisadds a way for callers to explicitly release non exact ranges
What changes are included in this PR?
This adds
clear_all_ranges(), which clears all byte ranges stillstaged in the decoder's internal
PushBuffersAre these changes tested?
yes
Are there any user-facing changes?
Yes, this adds a new public
clear_all_ranges()API onParquetMetaDataPushDecoder