Fix clippy warning in fixed_size_binary_array.rs#9712
Merged
alamb merged 1 commit intoapache:mainfrom Apr 16, 2026
Merged
Conversation
alamb
reviewed
Apr 14, 2026
| return Err(ArrowError::InvalidArgumentError( | ||
| "Buffer cannot have non-zero length if the item size is zero".to_owned(), | ||
| )); | ||
| let len = match values.len().checked_div(s) { |
Contributor
There was a problem hiding this comment.
what is the clippy lint that is triggered?
To be honest I found this formulation harder to read than the previous one
Contributor
Author
There was a problem hiding this comment.
its going to be clippy::manual_checked_ops which I think will be part of 1.95, I just ran into it because I was building with nightly.
Contributor
Author
There was a problem hiding this comment.
obviously this is a really nitpicky thing, glad to close this PR and just punt on it to whenever it becomes an actual issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is a future lint, so I took to the opportunity to make this it clear that the length validation only needs to happen in one case.
What changes are included in this PR?
Minor changes to validation in
FixedSizeBinaryArray::try_new.Are these changes tested?
Added some assertions to existing tests.
Are there any user-facing changes?
None