Refactor RleEncoder::flush_bit_packed_run to make flow clearer#9735
Open
etseidl wants to merge 1 commit intoapache:mainfrom
Open
Refactor RleEncoder::flush_bit_packed_run to make flow clearer#9735etseidl wants to merge 1 commit intoapache:mainfrom
RleEncoder::flush_bit_packed_run to make flow clearer#9735etseidl wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
cc @HippoBaro as this may conflict with your work |
Contributor
|
run benchmark arrow_writer |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing refactor_rle_flush (15dc1d1) to 38d78c3 (merge-base) diff File an issue against this benchmark runner |
Contributor
|
Looks good to me, the code comments are also clearer now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RleEncoder::flush_bit_packed_run#9734.Rationale for this change
The transition from bit-packed to RLE encoding is a bit confusing. See issue for more details.
What changes are included in this PR?
Splits
flush_bit_packed_runinto two functions and modifiesflush_buffered_valuesto use the newfinish_bit_packed_run.Are these changes tested?
Should be covered by existing tests
Are there any user-facing changes?
No, only makes changes to APIs marked experimental