Remove len field from buffer builder#9750
Conversation
|
run benchmark builder json_reader take_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing remove_buffer_builder_len (61b9178) to 89b1497 (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing remove_buffer_builder_len (61b9178) to 89b1497 (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing remove_buffer_builder_len (61b9178) to 89b1497 (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
My analysis of the benchmark results is that this change has no appreciable change in performance on those runs. Since it cleans things up, let's merge it in! |
Which issue does this PR close?
Rationale for this change
The buffer builder doesn't need to keep its own
lenfield, as it can be derived from the inner mutablebufferWhat changes are included in this PR?
Removes the
lenfield fromBufferbuilderAre these changes tested?
Yes, all tests green
Are there any user-facing changes?
Nope!