Skip to content

docs: Update contributing guidelines with benchmark results#9782

Merged
alamb merged 3 commits intoapache:mainfrom
alamb:alamb/performance_docs
Apr 29, 2026
Merged

docs: Update contributing guidelines with benchmark results#9782
alamb merged 3 commits intoapache:mainfrom
alamb:alamb/performance_docs

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Apr 21, 2026

Which issue does this PR close?

  • Closes #NNN.

Rationale for this change

As we get more PRs with performance improvements, I think it is important to make sure our expectations are documented -- namely that any PR for improving performance includes benchmark results

What changes are included in this PR?

  1. Update contributing guidelines
  2. Add a reminder in the PR template

Are these changes tested?

N/a

Are there any user-facing changes?

New docs

@alamb alamb added the documentation Improvements or additions to documentation label Apr 21, 2026
@alamb alamb marked this pull request as ready for review April 22, 2026 04:05
Copy link
Copy Markdown
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Apr 29, 2026

Thanks @etseidl

@alamb alamb merged commit 5255de4 into apache:main Apr 29, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants