refactor(ipc): derive Default for CompressionContext#9809
Merged
alamb merged 1 commit intoapache:mainfrom Apr 24, 2026
Merged
Conversation
Contributor
Author
|
CC @alamb |
alamb
approved these changes
Apr 24, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Love it -- thank you @mbutrovich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #9808.
Rationale for this change
After #9808 changed the zstd
Compressorfield toOption, the manualimpl DefaultforCompressionContextjust sets it toNone, which is identical to the derivedDefault. The#[allow(clippy::derivable_impls)]annotation confirms this was already a known issue.What changes are included in this PR?
Replace the manual
impl Default for CompressionContextwith#[derive(Default)]and remove theclippy::derivable_implsallow.Are these changes tested?
Existing tests cover this. The struct's default behavior is unchanged.
Are there any user-facing changes?
No.