[arrow-ipc]: dictionary builders for delta - doc fix and integration tests for nested types#9853
Merged
alamb merged 5 commits intoapache:mainfrom May 3, 2026
Conversation
albertlockett
changed the title
Contributor
Author
|
@JakeDern would you mind having a look at this? |
Contributor
Looks good to me, thanks for adding the tests! |
Contributor
|
FYI @adamreichold |
alamb
approved these changes
May 1, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @albertlockett and @JakeDern
| RecordBatch::try_new(schema.clone(), vec![Arc::new(array) as ArrayRef]).unwrap() | ||
| } | ||
|
|
||
| /// build batches where the dictionary array is nested within a struct array |
Contributor
There was a problem hiding this comment.
is it worth also mentioning that the dict array is the first array?
Contributor
|
Thanks @albertlockett |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In #9600 we added capability to call
finish_preserve_valueson any array builder, and it will propagate the choice to preserve dictionary values down into the nested builders. I thought it would be good to extend the integration tests we have in https://github.com/apache/arrow-rs/blob/main/arrow-ipc/tests/test_delta_dictionary.rs to cover the use cases, which was to call the method on builders with nested child builders (such asStructBuilderandListBuilder).While reviewing the PR for #9600 I also noticed a small issue with the docs related to using the StreamWriter with delta dictionaries, notably that we set up some options to use delta dictionaries but don't pass the options into the
StreamWriterconstructor:https://docs.rs/arrow-ipc/58.1.0/arrow_ipc/writer/struct.StreamWriter.html#example---efficient-delta-dictionaries
What changes are included in this PR?
ListBuilderandStructBuilderStreamWriterAre these changes tested?
it is simply docs & tests
Are there any user-facing changes?
No