Revised pr 9856#9919
Open
Rich-T-kid wants to merge 2 commits intoapache:mainfrom
Open
Conversation
The specialized interleave works by preserving run ends as much as possible by coalescing groups of adjacent logical indices pointing to the same source and calling interleave on the run end values. Future work could additionally coalesce values across sources, but this requires a value equality check. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
see #9856 & #9865 for more context
Rationale for this change
adds special path for interleave on REE arrays. @asubiotto worked on the ground work for this in #9856 I added the comparison check + arrayData cache, and a couple test from my branch.
What changes are included in this PR?
interleave on REE arrays now has a special path, also
`
[1, 1, 0, 0, 1, 1]
arr.extend(0, 2)
arr.extend(4, 6)
Now result in
runs: [4], values: [1]
instead of
runs: [2, 4], values: [1, 1]`
Are these changes tested?
yes
Are there any user-facing changes?
no