Fix MSRV check by checking in Cargo.lock#9941
Merged
alamb merged 1 commit intoapache:mainfrom May 7, 2026
Merged
Conversation
Jefffrey
approved these changes
May 7, 2026
Contributor
Jefffrey
left a comment
There was a problem hiding this comment.
I wonder if we'll need to bump open PR limit and/or group these other dependency updates like we did in DataFusion
Merged
Contributor
Author
I think arrow has many fewer dependencies so I am hoping we can avoid having to do so, but I suppose we'll see |
Contributor
Author
|
Thank you for the review @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: All of this PR is
Cargo.lock. I swear it is easy to review...Which issue does this PR close?
tonic@0.14.6#9938.Rationale for this change
The guidance on lock files from the Cargo folks changed a while ago: https://blog.rust-lang.org/2023/08/29/committing-lockfiles/
The MSRV check is failing on
mainbecause dependency resolution currently uses the latest compatible versions from crates.io for each package. The newesttonicrelease now require a newer Rust version than the workspace MSRV.Here is the reported CI failure: https://github.com/apache/arrow-rs/actions/runs/25472344356/job/74738606768
What changes are included in this PR?
This PR checks in a root
Cargo.lockso CI verifies MSRV against the dependency set we control, rather than the tip of all dependency ranges. The generated lockfile pins thetonic0.14 crates to0.14.5, which supports Rust 1.85.Note this does not change code in the crates. It only pins dependency resolution for workspace builds and CI.
This will result in more dependabot PRs to explicitly update the crate versions, but I think that is a good thing. I think the existing config file will work fine https://github.com/apache/arrow-rs/blob/main/.github/dependabot.yml
Are these changes tested?
Yes, by CI
This passed locally with Rust 1.85.0.
Are there any user-facing changes?
No. This only checks in the root lockfile used for dependency resolution in workspace builds and CI.