Skip to content

Remove deprecated parquet::format module and thrift dependency#9962

Open
jhorstmann wants to merge 1 commit into
apache:mainfrom
jhorstmann:remove-deprecated-apache-thrift
Open

Remove deprecated parquet::format module and thrift dependency#9962
jhorstmann wants to merge 1 commit into
apache:mainfrom
jhorstmann:remove-deprecated-apache-thrift

Conversation

@jhorstmann
Copy link
Copy Markdown
Contributor

@jhorstmann jhorstmann commented May 11, 2026

Which issue does this PR close?

Rationale for this change

Removal of the parquet::format was planned for the 59.0 Release (#9110) according to code comments. There is also now a security advisory against the Apache Thrift Rust implementation (GHSA-2f9f-gq7v-9h6m), for which there is no fixed release yet on crates.io.

What changes are included in this PR?

  • Removal of the Apache Thrift dependency
  • Removal of the deprecated parquet::format module
  • Changes to the parquet-layout binary to remove printing of page details, since that still depended on the deprecated code

Are these changes tested?

Existing tests pass as the code was unused.

Are there any user-facing changes?

Breaking api change, since parquet::format was a public module.

The output of the parquet-layout binary changes.

@github-actions github-actions Bot added the parquet Changes to the parquet crate label May 11, 2026
Copy link
Copy Markdown
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhorstmann! You beat me to it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apache Thrift has a Memory Allocation with Excessive Size Value Vulnerability

2 participants