Add helper functions to create LogicalType struct variants#9996
Merged
Conversation
Contributor
|
Looks good to me, nice to have fewer places to spell out |
alamb
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
The new pattern looks good to me -- thanks @etseidl and @jhorstmann
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
LogicalTypeenum to macro generated version #9995.Rationale for this change
Before switching
LogicalTypefrom struct variants to tuple variants, add some helper functions that will hide some of the increase in complexity.What changes are included in this PR?
Adds functions to the
LogicalTypeimpl for creating instances of the non-unit variants (Integer,Decimal,Time,Timestamp,Variant,Geometry,Geography).Are these changes tested?
Should be covered by existing tests.
Are there any user-facing changes?
Adds to the
LogicalTypeAPI