ARROW-15786: [Website] Tidy use of and linking to Arrow logo#198
Merged
Conversation
ianmcook
approved these changes
Apr 11, 2022
Member
|
@djnavarro this slipped off my radar for a long time. I apologize for the delay reviewing and merging it! I agree that it is probably not worthwhile to update the other uses of the logo, for the reasons you cite above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
powered_bypage, linking it to thevisual_identitypage and uses one of the new logo files for that page.arrow-inverse.png, and the navbar header usesarrow-inverse-300px.png. I could switch those too, but I'm not sure there's value in that: the new files have more whitespace surrounding them, so I'd have to end up recreating exact replicas of the existing files if we wanted to preserve the (IMO very nice) tight vertical spacing on the site banner and the navbar.As far as I can tell this is all that's needed?