Skip to content

MINOR: [Website] Fix a typo in arrow-parquet-encoding-part-2#267

Merged
alamb merged 2 commits intoapache:masterfrom
Ted-Jiang:fix_arrow-parquet-encoding-part-2
Nov 5, 2022
Merged

MINOR: [Website] Fix a typo in arrow-parquet-encoding-part-2#267
alamb merged 2 commits intoapache:masterfrom
Ted-Jiang:fix_arrow-parquet-encoding-part-2

Conversation

@Ted-Jiang
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2022

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

```

A definition level of `1` would imply a null at the level of `d`
A definition level of `1` would imply a null at the level of `d.d2`
Copy link
Copy Markdown
Member Author

@Ted-Jiang Ted-Jiang Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb @tustvold i think this should be d.d2🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think you are correct

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should probably also change the example to be valid JSON

"d": { }

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ted-Jiang -- I would like @tustvold to confirm as well

@kou kou changed the title [minor]fix arrow-parquet-encoding-part-2 MINOR: [Website] Fix a typo in arrow-parquet-encoding-part-2 Nov 4, 2022
```

A definition level of `1` would imply a null at the level of `d`
A definition level of `1` would imply a null at the level of `d.d2`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should probably also change the example to be valid JSON

"d": { }

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ted-Jiang and @tustvold

@alamb alamb merged commit f654bf4 into apache:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants