Conversation
Member
|
But so based on your description, we should actually not merge this PR and keep your commit? |
Member
Author
Yes, that is correct and yeah, it is a total mess. I don't really want to make another plain commit to revert the changes I accidently pushed. But can do that if it would be clearer overall. |
Member
Author
|
Closing this PR as the accidental commit works and this PR is left as a tracker for the issue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made an accidental commit with the change I meant to propose as a PR here: 7714fe8.
What I meant to propose as a PR but accidentally committed
I have noticed that the version
12.0of the documentation got created in theversions.json- probably when the bug-fix release has been done. So currently the link in the docs dropdown has12.0 (stable)and12.0listed but the later does not exist yet.I propose to remove the
12.0entry from theversions.jsonfor now and I will make an issue in the main Arrow repo if the behaviour is indeed buggy and needs to be fixed.What is this PR mean for?
To revert the changes I have accidentally committed if the proposed changes are not correct.