Add ATProtocol handle resolution file#587
Conversation
This should allow our BlueSky account to use the handle "@arrow.apache.org".
| include: | ||
| - _static | ||
| - .well-known |
There was a problem hiding this comment.
To be honest I am not sure what this include does but I think we should just copy the file on the deploy step:
arrow-site/.github/workflows/deploy.yml
Lines 80 to 81 in aaa5896
From the comments on this PR, I think this is where we copy it:
#506
There was a problem hiding this comment.
The addition ensures that the .well-known directory and its contents is included in the generated site.
Is there a reason to prefer a shell cp command? I find it cleaner to rely as much as possible on configuration, rather than dedicated shell commands. Also, using _config.yml I could actually test my changes locally.
@kou What do you think?
There was a problem hiding this comment.
If this has been tested and works, I agree, this sounds like a better solution than manually cp files. We probably want to have a single way of doing this for the other files we are copying.
Thanks for finding out!
There was a problem hiding this comment.
Ah, we should use include instead of raw cp for them too.
Sorry, I didn't notice this approach when I did it.
|
Ok, let's merge and check that this did work as expected! |
|
This seems to work now: |
|
One button still needed to be pressed, but now the handle is updated as well :) |
4 participants
This should allow our BlueSky account to use the handle "@arrow.apache.org".