Skip to content

Release docs 20.0.0#643

Merged
assignUser merged 3 commits intoapache:asf-sitefrom
assignUser:release-docs-20.0.0
Apr 30, 2025
Merged

Release docs 20.0.0#643
assignUser merged 3 commits intoapache:asf-sitefrom
assignUser:release-docs-20.0.0

Conversation

@assignUser
Copy link
Member

No description provided.

@assignUser assignUser requested a review from amoeba April 28, 2025 12:02
@amoeba
Copy link
Member

amoeba commented Apr 28, 2025

Thanks! This still has the issue we hadn't fixed involving the warning banner. On the stable docs in this PR, the <script> tag is still,

<script>
    DOCUMENTATION_OPTIONS.theme_version = '0.16.1';
    DOCUMENTATION_OPTIONS.theme_switcher_json_url = '/docs/_static/versions.json';
    DOCUMENTATION_OPTIONS.theme_switcher_version_match = '';
    DOCUMENTATION_OPTIONS.show_version_warning_banner =
        true;   <---- this should be false but our script doesn't catch it with the 
</script>

We should change it to,

    <script>
        DOCUMENTATION_OPTIONS.theme_version = '0.16.1';
        DOCUMENTATION_OPTIONS.theme_switcher_json_url = '/docs/_static/versions.json';
        DOCUMENTATION_OPTIONS.theme_switcher_version_match = '';
        DOCUMENTATION_OPTIONS.show_version_warning_banner = false;
        </script>

before we merge this.

Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, tested locally. Thanks.

@assignUser assignUser merged commit eb1d3bd into apache:asf-site Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants