update int64 columns to use string values#31
Merged
wesm merged 3 commits intoapache:masterfrom Jun 29, 2020
Merged
Conversation
Member
|
It's possible this dictionary test uses strings too https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/datagen.py#L1426 |
Contributor
Author
|
Thanks updated the dictionary.json.gz as well. |
Member
|
Can you explain the changes done? |
Contributor
Author
|
Changes:
|
Member
|
I thanks. I hadn't noticed those were the JSON files. |
Member
|
@emkornfield @pitrou I'll try to test these locally |
Member
|
Ah the interval and datetime tests also have the issue https://gist.github.com/wesm/bf650d27557e90b4833054ab01783623 I'll try to fix them locally |
Member
|
OK, passing now (fun times with emacs regexp-replace). https://gist.github.com/wesm/b7ed6934ef7753c2087919156c751bf4 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wesm I hand edited (with vim macro) and then verified it can be parsed with python (I didn't rerun integration tests. Is there an easy way to do that? Also it looks like the only int64 usage I could find is with primitives (the file edited and zero batch test cases).