ARTEMIS-1312 TimedBuffer doubled timeout with blocking flush#1433
Closed
franz1981 wants to merge 1 commit intoapache:masterfrom
Closed
ARTEMIS-1312 TimedBuffer doubled timeout with blocking flush#1433franz1981 wants to merge 1 commit intoapache:masterfrom
franz1981 wants to merge 1 commit intoapache:masterfrom
Conversation
| sleepIfPossible(); | ||
| //it could wait until the timeout is expired | ||
| final long timeFromTheLastFlush = System.nanoTime() - lastFlushTime; | ||
| final long timeToSleep = timeFromTheLastFlush - timeout; |
Contributor
There was a problem hiding this comment.
You are basically discounting the time it took to sync?
looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the TimedBuffer timeout expiration using the effective flush time (if available) to perform the sleep time after a submitted flush.
This wouldn't impact ASYNCIO that is supposed to be nonblocking on flush submission, but will let NIO/MAPPED to have the timeout matching the configured IOPS.