ARTEMIS-1577 Address-settings policies not working with older clients#1787
ARTEMIS-1577 Address-settings policies not working with older clients#1787clebertsuconic wants to merge 1 commit into
Conversation
clebertsuconic
force-pushed
the
compatibility
branch
from
fcf5bfb to
d82b576
Compare
| AtomicBoolean startedTX = new AtomicBoolean(false); | ||
|
|
||
| final SimpleString address = message.getAddressSimpleString(); | ||
| final SimpleString address = context.getAddress(message); |
There was a problem hiding this comment.
Can we not make the call to context.getAddress just the once, and re-use the result throughout the method call?
eg. this line could be before setPagingStore, and simply use address else where.
There was a problem hiding this comment.
I'm just going for the simple refactoring here.. every call to message.getAddressSimplString() to be calling context.getAddress()
There was a problem hiding this comment.
Your comment could apply to the previous version as well.. I didn't make any big changes here. nor did want to risk anything else.
|
|
||
| if (duplicateIDBytes != null) { | ||
| cache = getDuplicateIDCache(message.getAddressSimpleString()); | ||
| cache = getDuplicateIDCache(context.getAddress(message)); |
There was a problem hiding this comment.
Same as other comment, re making one call to context.getAddress(message) and re-using the result
There was a problem hiding this comment.
@michaelandrepearce caching here goes beyond the scope here.
I would need to change a lot of signatures to pass an address as a parameter.. or cache within each method used during routing.
We can do that.. but it goes beyond the scope of this fix.
There was a problem hiding this comment.
No worries I can do separate pr later
|
+1 I’m happy as noted I can pr some bits later |
2 participants
This closes #1744