Added acknowledgements for messages expired without expiry address bindings#1920
Closed
ilkkavi wants to merge 1 commit into
Closed
Added acknowledgements for messages expired without expiry address bindings#1920ilkkavi wants to merge 1 commit into
ilkkavi wants to merge 1 commit into
Conversation
Contributor
|
This change needs a JIRA and a test as well. |
Contributor
|
I wanted to keep your commit, but I also wanted to get this merged so it can be included in the upcoming 2.5 release. Therefore, I sent #1930 which has your commit with and updated commit message (to reference the JIRA) as well as a few tests to reproduce the issue and ensure no regressions later. Please close this PR. Thanks! |
Author
|
Excellent, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referring to a resource leak and JMX reporting expired messages as in-delivery as discussed in the user mailing list between 2018-02-21 and 2018-03-01. I was unable to reproduce the OOM after this change. Would you care to comment on this, if possible?
http://activemq.2283324.n4.nabble.com/Artemis-2-4-0-Issues-with-memory-leaks-and-JMS-message-redistribution-td4736891.html