ARTEMIS-1924 Add amqpIdleTimeout#2135
Merged
asfgit merged 1 commit intoapache:masterfrom Jun 11, 2018
Merged
Conversation
clebertsuconic
force-pushed
the
ARTEMIS-1924
branch
2 times, most recently
from
f1468d1 to
9d1b72f
Compare
Contributor
|
Code looks good. Add a paragraph to the docs and it should be good to go. |
tabish121
reviewed
Jun 11, 2018
|
|
||
|
|
||
| @Test(timeout = 60000) | ||
| public void testBrokerSendsHalfConfiguredIdleTimeout() throws Exception { |
Contributor
There was a problem hiding this comment.
The name of the test doesn't appear to match what is being tested here so I'd name it something that actually describes that to avoid confusing folks.
Contributor
Author
There was a problem hiding this comment.
ouch.. you're right.. and I missed it.. I will rename right away.
the joy of copy & paste
Contributor
Author
There was a problem hiding this comment.
will call it testHeartless :)
clebertsuconic
force-pushed
the
ARTEMIS-1924
branch
from
9d1b72f to
cb793e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.