ARTEMIS-2354 Fix compilation issues on JDK 8#2720
Closed
franz1981 wants to merge 1 commit intoapache:masterfrom
Closed
ARTEMIS-2354 Fix compilation issues on JDK 8#2720franz1981 wants to merge 1 commit intoapache:masterfrom
franz1981 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
I'm waiting the CI to finish test this 👍 |
franz1981
force-pushed
the
jdk_11
branch
2 times, most recently
from
de7f6ef to
0482363
Compare
Contributor
|
Can't you fix it rather than revert it? |
This reverts partially commit f8d3a8f to include only the changes that makes possible to run tests with JDK 11: compile on JDK 11 is outside the scope of the issue. JDK 11 compilation requires Karaf upgrade, that will break compatibility with Aether on integration-tests.
Contributor
|
don't merge this yet pls |
franz1981
changed the title
Contributor
Author
|
@clebertsuconic CI has shown that the change seems to compile correctly with JDK 8 |
Closed
gemmellr
added a commit
to gemmellr/artemis
that referenced
this pull request
Jun 9, 2020
…roblem in artemis-dto in my env
ehsavoie
pushed a commit
to ehsavoie/activemq-artemis
that referenced
this pull request
Jun 11, 2020
…roblem in artemis-dto in my env
gemmellr
added a commit
to gemmellr/artemis
that referenced
this pull request
Jun 11, 2020
…roblem in artemis-dto in my env
gemmellr
added a commit
to gemmellr/artemis
that referenced
this pull request
Jun 11, 2020
…und from apache#2720 updated to only cause a change if the generated schema element found isnt prefixed, i.e modifies xsd only when needed and not all the time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts partially commit f8d3a8f to include only
the changes that makes possible to run tests with JDK 11:
compile on JDK 11 is outside the scope of the issue.
JDK 11 compilation requires Karaf upgrade, that will
break compatibility with Aether on integration-tests.