Skip to content

NO-JIRA Fixing intermittent failure on CreditsSemaphoreTest #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clebertsuconic wants to merge 1 commit into from
Closed

NO-JIRA Fixing intermittent failure on CreditsSemaphoreTest #2822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...ol/src/test/java/org/apache/activemq/artemis/protocol/amqp/util/CreditsSemaphoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,14 @@ public void testDownAndUp() throws Exception {

Assert.assertEquals(0, semaphore.getCredits());

long timeout = System.currentTimeMillis() + 1000;
while (!semaphore.hasQueuedThreads() && System.currentTimeMillis() < timeout) {
// TODO: Wait.assertTrue is not available at this package. So, this is making what we would be doing with a Wait Clause
// we could replace this next block with a Wait clause on hasQueuedThreads
int i = 0;
for (i = 0; i < 1000 && !semaphore.hasQueuedThreads(); i++) {
Thread.sleep(10);
}

Assert.assertTrue(semaphore.hasQueuedThreads());
Assert.assertTrue(i < 1000);

semaphore.release(2);

Expand Down