ARTEMIS-2109: require JDK 8 for release#3183
Closed
gemmellr wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
…therwise, rename profiles for consistency and clarity, remove superflous/incorrect managed plugin versions Update CI to only use the release profile for building examples on JDK8, use noRun profile otherwise. Does the exact same in terms of setting properties for the examples build, just doesnt engage the parent release profile which enforces JDK8.
Member
Author
|
More changes following #3179 |
asfgit
pushed a commit
that referenced
this pull request
Jun 15, 2020
The plugin-management provided 1.4.1 enforcer version can it seems interact oddly with the assembly plugin depending on what else is in use, leading to an NPE in some cases.
Member
Author
|
I reverted the plugin version changes on master in 61e920d. I had noticed a NPE failure building the assembly during "mvn clean package" (but not "mvn clean install"), which some search suggeted relates to use of the enforcer plugin 1.4.1 in modules with pom packaging. That was the effective change from removing the 1.4 version definitions as the pluginManagement already has a 1.4.1 entry. Must be some sort of weird interaction with other bits in use as well, since we use 1.4.1+assembly in lots of other places, but anyway...I've restored that bit to how it was before to put things as they were. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires JDK 8 for the 'release' profile. This is the same requirement as before, but the existing profile check only set an '8 minimum' requirement. Now that it can build on 11+ (but, targetting 11 while doing so currently) unlike before, the check needs to be specifically 8-only.
Enforces use of JDK8 or 11+ in regular non-release builds, giving 9 or 10 users a clearer error.
Renames profiles for consistency and clarity.
Updates CI to not use the release profile for examples on 11 or 14, only 8.