ARTEMIS-3241 Update console packages licenses#3546
ARTEMIS-3241 Update console packages licenses#3546clebertsuconic merged 1 commit intoapache:mainfrom
Conversation
gemmellr
left a comment
gemmellr
left a comment
There was a problem hiding this comment.
Looks good other than one small thing...which it may not be possible to do anything about if thats all they give/distribute.
| Permission to use, copy, modify, distribute, and sell this software and its | ||
| documentation for any purpose is hereby granted without fee, provided that | ||
| the above copyright notice appear in all copies and that both that | ||
| copyright notice and this permission notice appear in supporting | ||
| documentation. No representations are made about the suitability of this | ||
| software for any purpose. It is provided "as is" without express or | ||
| implied warranty. |
There was a problem hiding this comment.
This seems a bit broken as it references retaining a copyright notice that doesnt exist..was there an alternative/complete text available?
There was a problem hiding this comment.
@gemmellr the angular-resizable project owner doesn't want to provide a copyright notice see Reklino/angular-resizable#82
There was a problem hiding this comment.
Mmm, guess theres not much we can do about that then. Seems an odd licence text to use given that though, and doesnt change who wrote what at all. I guess we did retain the non-existant notice space as intended though hehe.
There was a problem hiding this comment.
I could replace For details, see licenses/LICENSE-angular-resizable.txt with No license file provided
There was a problem hiding this comment.
@gemmellr I have just pushed a commit to remove the licenses/LICENSE-angular-resizable.txtfile and to add the comment No text license provided by the author
There was a problem hiding this comment.
No, we definitely shouldnt do that, as it does actually have a licence, an MIT variant, and it needs to or we probably cant use it. Just put it back the way it was, as silly as that is.
There was a problem hiding this comment.
I created the licenses/LICENSE-angular-resizable.txt by myself copying it from https://fedoraproject.org/wiki/Licensing:MIT because the product is available under the MIT license (see https://github.com/Reklino/angular-resizable#license) but I can not find any license file at https://github.com/Reklino/angular-resizable
Any MIT license refers to a copyright notice so there is no generic valid MIT license that we can use.
I would write: This product bundles angular-resizable, which is available under a "MIT" license. No text license provided by the author
There was a problem hiding this comment.
I think thats a little dodgy really. If he stipulates it is MIT licenced but refuses to add the copyright notice, it should probably use the full text of the licence minus the copyright.
There was a problem hiding this comment.
@gemmellr, I have found an example created by the same author with the angular-resizable sources and with a valid MIT license at https://codepen.io/Reklino/pen/raRaXq/
I have added the valid MIT licensed downloaded from https://codepen.io/Reklino/pen/raRaXq/ to the distribution
There was a problem hiding this comment.
Great. Somewhat bizarre, but great.
brusdev
force-pushed
the
update_console_licenses
branch
from
44a3899 to
dbe3867
Compare
brusdev
force-pushed
the
update_console_licenses
branch
from
dbe3867 to
3c90c69
Compare
brusdev
force-pushed
the
update_console_licenses
branch
from
a649f22 to
30ec887
Compare
|
Looks good to me, but someone actually familiar with the console bits should give it a look. |
3 participants
No description provided.