ARTEMIS-3337: Correctly handle multiple connection failures

artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java

@@ -802,13 +802,20 @@ private boolean reconnectSessions(final RemotingConnection oldConnection,
       // it needs to be done on the protocol
       ((CoreRemotingConnection) connection).syncIDGeneratorSequence(((CoreRemotingConnection) oldConnection).getIDGeneratorSequence());
 
+      boolean sessionFailoverError = false;
       for (ClientSessionInternal session : sessionsToFailover) {
-         if (!session.handleFailover(connection, cause)) {
-            return false;
+         if (sessionFailoverError) {
+            // If 1 session had a failover error, just detach the remaining sessions from the old connection so that
+            // they are not closed when the old connection is destroyed
+            session.getSessionContext().transferConnection(connection);
+         } else {
+            if (!session.handleFailover(connection, cause)) {
+               sessionFailoverError = true;
+            }
          }
       }
 
-      return true;
+      return !sessionFailoverError;
    }
 
    private void getConnectionWithRetry(final int reconnectAttempts, RemotingConnection oldConnection) {

artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java

@@ -823,11 +823,15 @@ public void createQueue(QueueConfiguration queueConfiguration) throws ActiveMQEx
    }
 
    @Override
-   public boolean reattachOnNewConnection(RemotingConnection newConnection) throws ActiveMQException {
-
+   public void transferConnection(RemotingConnection newConnection) {
       this.remotingConnection = newConnection;
-
       sessionChannel.transferConnection((CoreRemotingConnection) newConnection);
+   }
+
+   @Override
+   public boolean reattachOnNewConnection(RemotingConnection newConnection) throws ActiveMQException {
+
+      transferConnection(newConnection);
 
       Packet request = new ReattachSessionMessage(name, sessionChannel.getLastConfirmedCommandID());
 

artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/remoting/SessionContext.java

@@ -69,6 +69,11 @@ public void setSession(ClientSessionInternal session) {
 
    public abstract int getReconnectID();
 
+   /**
+    * Transfers the session context to the given newConnection on the client-side
+    */
+   public abstract void transferConnection(RemotingConnection newConnection);
+
    /**
     * it will either reattach or reconnect, preferably reattaching it.
     *