ARTEMIS-3453: exclude log4j transitive dep from zookeeper#3712
Merged
asfgit merged 1 commit intoapache:mainfrom Sep 1, 2021
Merged
ARTEMIS-3453: exclude log4j transitive dep from zookeeper#3712asfgit merged 1 commit intoapache:mainfrom
asfgit merged 1 commit intoapache:mainfrom
Conversation
…eper dependencyManagement entry
Contributor
|
+1 it is the way to go |
Contributor
|
Will give a shot to see what can happen here |
Member
Author
|
I dont see any examples depending on zookeeper directly, so I'm going to push the change as-is, can always follow up if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARTEMIS-3453
Didnt test this at all yet other than seeing its effect on the main build. Seems the way to go though so raising for a PR run and any input from others.
In particular, by excluding sl4fj-log4j and log4j across the board, it may be necessary to add other dependencies to some modules (examples?) if they lack a another means of output such as another slf4j bridge.