ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections#3789
Merged
gtully merged 1 commit intoapache:mainfrom Oct 7, 2021
Merged
ARTEMIS-3520: set Open hint upon redirect/refusal of AMQP connections#3789gtully merged 1 commit intoapache:mainfrom
gtully merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
Oops, I was in the test dir when I fixed checkstyle issues, missed the other bit. |
…fuses AMQP connection, add lower level test for balancer related redirect/refusal protocol behaviour
gemmellr
force-pushed
the
balancer-open-fail-hint
branch
from
b092321 to
fe75dba
Compare
brusdev
approved these changes
Oct 7, 2021
Contributor
|
this sorts the NPE in the new balancer example, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the Open frame failure hint property when the broker balancer decides to redirect or refuse an AMQP connection, so aware clients know they need not proceed on receipt of the Open as a Close will follow. Adds some more direct tests of the protocol behaviour during refusal or redirect of initial connection by the balancer.
Also adds some context to failure messages from other existing Redirect tests, as some asserts are in loops and cant be fully reasoned about without detail then no longer available (meant to put that in a separate commit, but didn't seem worth separating it again once I forgot to commit it).